Compare commits

..

2 Commits

Author SHA1 Message Date
clawdbot
5ff0c22724 refactor(editor): unify selection key + clean node view 2026-01-28 22:27:09 +08:00
clawdbot
e296fc0979 refactor: centralize selection key helper 2026-01-28 22:10:34 +08:00
4 changed files with 21 additions and 27 deletions

View File

@ -5,6 +5,7 @@ import { Button, Space } from 'antd';
import type { ResizeHandle } from './types'; import type { ResizeHandle } from './types';
import { rectFromPoints } from './geometry'; import { rectFromPoints } from './geometry';
import type { ContextMenuState } from './ContextMenu'; import type { ContextMenuState } from './ContextMenu';
import { selectionKeyOf } from './selection';
export interface CanvasProps { export interface CanvasProps {
screen: Screen; screen: Screen;
@ -40,12 +41,6 @@ function isPrimaryButton(e: React.PointerEvent | PointerEvent): boolean {
return (e as PointerEvent).buttons === 1 || (e as PointerEvent).button === 0; return (e as PointerEvent).buttons === 1 || (e as PointerEvent).button === 0;
} }
function selectionKeyOf(ids: string[]): string {
// Keep stable regardless of selection order.
// This avoids false mismatches between context-menu state and reducer state.
return [...ids].sort().join('|');
}
export function Canvas(props: CanvasProps) { export function Canvas(props: CanvasProps) {
const ref = useRef<HTMLDivElement | null>(null); const ref = useRef<HTMLDivElement | null>(null);
const [box, setBox] = useState<{ x1: number; y1: number; x2: number; y2: number } | null>(null); const [box, setBox] = useState<{ x1: number; y1: number; x2: number; y2: number } | null>(null);
@ -441,18 +436,18 @@ function NodeView(props: {
boxSizing: 'border-box', boxSizing: 'border-box',
padding: `${node.props.paddingY ?? 0}px ${node.props.paddingX ?? 0}px`, padding: `${node.props.paddingY ?? 0}px ${node.props.paddingX ?? 0}px`,
overflow: 'hidden', overflow: 'hidden',
}}
>
<span
style={{
whiteSpace: 'pre-wrap',
fontSize: node.props.fontSize ?? 24,
color: node.props.color ?? '#fff',
fontWeight: node.props.fontWeight ?? 400,
letterSpacing: `${node.props.letterSpacing ?? 0}px`,
writingMode: writingModeStyle,
cursor: node.props.link ? 'pointer' : 'default',
}} }}
>
<span
style={{
whiteSpace: 'pre-wrap',
fontSize: node.props.fontSize ?? 24,
color: node.props.color ?? '#fff',
fontWeight: node.props.fontWeight ?? 400,
letterSpacing: `${node.props.letterSpacing ?? 0}px`,
writingMode: writingModeStyle,
cursor: node.props.link ? 'pointer' : 'default',
}}
onClick={() => { onClick={() => {
if (!node.props.link) return; if (!node.props.link) return;
const head = node.props.linkHead ?? 'http://'; const head = node.props.linkHead ?? 'http://';

View File

@ -1,11 +1,7 @@
import { useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react'; import { useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react';
import { Typography } from 'antd'; import { Typography } from 'antd';
function selectionKeyOf(ids: string[]): string { import { selectionKeyOf } from './selection';
// Keep stable regardless of selection order.
// This avoids false mismatches between context-menu state and reducer state.
return [...ids].sort().join('|');
}
export type ContextMenuState = export type ContextMenuState =
| { | {

View File

@ -14,6 +14,7 @@ import { bindEditorHotkeys } from './hotkeys';
import { Canvas } from './Canvas'; import { Canvas } from './Canvas';
import { ContextMenu, type ContextMenuState } from './ContextMenu'; import { ContextMenu, type ContextMenuState } from './ContextMenu';
import { Inspector } from './Inspector'; import { Inspector } from './Inspector';
import { selectionKeyOf } from './selection';
import { createInitialState, editorReducer, exportScreenJSON } from './store'; import { createInitialState, editorReducer, exportScreenJSON } from './store';
const { Header, Sider, Content } = Layout; const { Header, Sider, Content } = Layout;
@ -86,10 +87,7 @@ export function EditorApp() {
const closeContextMenu = useCallback(() => setCtxMenu(null), []); const closeContextMenu = useCallback(() => setCtxMenu(null), []);
const selectionKeyOf = useCallback((ids: string[]) => { // selectionKeyOf imported from ./selection
// Keep stable regardless of ordering.
return [...ids].sort().join('|');
}, []);
const ctxMenuSyncedRef = useRef(false); const ctxMenuSyncedRef = useRef(false);
@ -103,7 +101,7 @@ export function EditorApp() {
} }
dispatch(action); dispatch(action);
}, },
[ctxMenu, dispatch, selectionKeyOf, state.selection.ids], [ctxMenu, dispatch, state.selection.ids],
); );
useEffect(() => { useEffect(() => {

View File

@ -0,0 +1,5 @@
export function selectionKeyOf(ids: string[]): string {
// Keep stable regardless of selection order.
// This avoids false mismatches between context-menu state and reducer state.
return [...ids].sort().join('|');
}