From 31ad748735a989aad7dafb0ac16415023e458e47 Mon Sep 17 00:00:00 2001
From: clawdbot <clawdbot@local>
Date: Thu, 29 Jan 2026 00:44:44 +0800
Subject: [PATCH] refactor(sdk): stabilize widget kinds + broaden goView media
 keys

---
 packages/sdk/src/core/goview/convert.ts | 13 ++++++++++++-
 packages/sdk/src/core/schema.ts         |  9 ++++++---
 2 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/packages/sdk/src/core/goview/convert.ts b/packages/sdk/src/core/goview/convert.ts
index 4bfa2ba..39cb578 100644
--- a/packages/sdk/src/core/goview/convert.ts
+++ b/packages/sdk/src/core/goview/convert.ts
@@ -137,6 +137,12 @@ function isIframe(c: GoViewComponentLike): boolean {
     k.includes('browser') ||
     k.includes('webpage') ||
     k.includes('website') ||
+    // Dashboard/report embeds are almost always iframes.
+    k.includes('grafana') ||
+    k.includes('powerbi') ||
+    k.includes('metabase') ||
+    k.includes('superset') ||
+    k.includes('tableau') ||
     // Chinese low-code widgets / dashboards sometimes label this more directly.
     k.includes('网页') ||
     k.includes('嵌入') ||
@@ -199,19 +205,24 @@ function isVideo(c: GoViewComponentLike): boolean {
   return (
     k.includes('mp4') ||
     k.includes('media') ||
+    // "player" is broad; keep it but prefer more specific matches above.
     k.includes('player') ||
     // player implementation names frequently used in low-code widgets
     k.includes('flvjs') ||
     k.includes('hlsjs') ||
     k.includes('dplayer') ||
     k.includes('vlc') ||
+    // streaming/protocol keywords (often used directly as widget keys)
     k.includes('stream') ||
     k.includes('rtsp') ||
     k.includes('rtmp') ||
+    k.includes('webrtc') ||
+    k.includes('srt') ||
+    k.includes('wss') ||
+    k.includes('ws') ||
     k.includes('hls') ||
     k.includes('m3u8') ||
     k.includes('flv') ||
-    k.includes('webrtc') ||
     k.includes('dash') ||
     // common low-code names for live streams
     k.includes('live') ||
diff --git a/packages/sdk/src/core/schema.ts b/packages/sdk/src/core/schema.ts
index 060e233..0481758 100644
--- a/packages/sdk/src/core/schema.ts
+++ b/packages/sdk/src/core/schema.ts
@@ -15,9 +15,14 @@ export interface Transform {
   scaleY?: number;
 }
 
+// Keep this as a literal union (instead of inferring from WidgetNode['type']) so that
+// discriminated-union narrowing stays stable across packages and we avoid accidental `never`
+// issues in editor switch statements.
+export type WidgetKind = 'text' | 'image' | 'iframe' | 'video';
+
 export interface WidgetNodeBase {
   id: string;
-  type: string;
+  type: WidgetKind;
   rect: Rect;
   transform?: Transform;
   locked?: boolean;
@@ -90,8 +95,6 @@ export interface VideoWidgetNode extends WidgetNodeBase {
 
 export type WidgetNode = TextWidgetNode | ImageWidgetNode | IframeWidgetNode | VideoWidgetNode;
 
-export type WidgetKind = WidgetNode['type'];
-
 export type WidgetNodeByType = {
   text: TextWidgetNode;
   image: ImageWidgetNode;